[Chat] 채팅 수정 API 구현 #166
Merged
[Chat] 채팅 수정 API 구현 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yudonggeun
approved these changes
Jun 11, 2024
| when (request.type) { | ||
| ChatType.Room -> chatService.updateRoomChat(request, userId) | ||
| ChatType.Server -> chatService.updateServerChat(request, userId) | ||
| else -> throw GlobalException(ErrorCode.INVALID_CHAT_TYPE) |
There was a problem hiding this comment.
request 생성시에 invalid chat type 이라면 예외가 발생해서 이 코드는 히트하는 경우가 없을 것 같아요.
Comment on lines
29
to
33
| fun verifyAccess(userId: String) { | ||
| if (userId != this.userId) { | ||
| throw GlobalException(ErrorCode.FORBIDDEN_CHAT) | ||
| } | ||
| } |
There was a problem hiding this comment.
내부 구현을 보지 않으면 무슨 검증인지 바로 알기는 힘들어보여서 좀 더 명확한 이름으로 수정하는 것은 어떨까요?
verifyAccess가 도메인에 어울리는 기능인가요? 서비스에 어울리는 기능인가요?
There was a problem hiding this comment.
넵 이름을 구체적으로 수정해보겠습니다!
Chat model이 다른데에서도 사용될 수 있다고 생각하고 재사용하는 경우를 생각하며 저렇게 짰는데 생각해보니 ChatService이외에는 쓰지 않을 것 같고 로직 자체는 Service단의 로직에 더 가까운 것 같아서 Service 단으로 옮기는 게 나을 것 같네요~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#165
📝작업 내용
채팅을 수정하는 기능을 구현했습니다
💬리뷰 요구사항
기존에 Repository를 Server의 Chat과 Room의 Chat을 나누면서
model도 따로따로 생성해서 사용했었는데 오늘 보니까 ServerChat과 RoomChat에서 다른것은 serverId/ roomId밖에 없길래 두 모델을 하나의 모델로 (Chat으로) 합쳤습니다